Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPAL-413 Add tfsec commenter to the build #541

Closed
wants to merge 16 commits into from

Conversation

williamfalconeruk
Copy link
Contributor

Purpose

Briefly describe the purpose of the change, and/or link to the JIRA ticket for context

Fixes LPAL-####

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the LPA service

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added mandatory tags to terraformed resources, where possible
  • If I added a package.json or composer.json, I also made sure this is included in the script in .github/workflows/dependabot-update.yml
  • The product team have tested these changes

@williamfalconeruk williamfalconeruk marked this pull request as ready for review July 13, 2021 11:22
@williamfalconeruk williamfalconeruk requested a review from a team as a code owner July 13, 2021 11:22
@townxelliot townxelliot changed the title LPAL-413vAdd tfsec commenter to the build LPAL-413 Add tfsec commenter to the build Jul 13, 2021
@williamfalconeruk
Copy link
Contributor Author

williamfalconeruk commented Jul 19, 2021

closing for now as we have a scanning action in place. see PR #548. Will either reopen or create a new PR when we have further info. the commenter may be useful.

@Raffers Raffers deleted the LPAL-413-add-tfsec-action branch November 17, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant