Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPAL-556 remove non regional key #678

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

williamfalconeruk
Copy link
Contributor

Purpose

to schedule key deletion of the non regional key, and to add new eu-west-2 aws creds (London) in preparation for trying out DR practice.

Fixes LPAL-556

Approach

revert previous terraform for CMK
Add region credentials for London.

Learning

2 items not in AWS provider as yet means we have to do these outside of the Terraform:

Nonetheless we'll continue to experiment with creating a stood up version in London using the CLI / Console as an approach.

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added mandatory tags to terraformed resources, where possible
  • If I added a package.json or composer.json, I also made sure this is included in the script in .github/workflows/dependabot-update.yml
  • The product team have tested these changes

@williamfalconeruk williamfalconeruk requested a review from a team as a code owner October 13, 2021 10:38
@williamfalconeruk williamfalconeruk changed the title LPAL-556 remove useful keys LPAL-556 remove non regional key Oct 13, 2021
@williamfalconeruk williamfalconeruk merged commit ce4e208 into main Oct 13, 2021
@williamfalconeruk williamfalconeruk deleted the LPAL-Create-cross-region-key-for-dr branch October 13, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants