Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-2740 - implement the firewalled network #1664

Conversation

andrewpearce-digital
Copy link
Contributor

@andrewpearce-digital andrewpearce-digital commented Dec 5, 2024

Purpose

Manage egress from the network and limit to specific endpoints

Fixes MLPAB-2740

Approach

  • Use fire walled network module in place of network module

Learning

@andrewpearce-digital andrewpearce-digital marked this pull request as ready for review December 5, 2024 10:27
@andrewpearce-digital andrewpearce-digital requested a review from a team as a code owner December 5, 2024 10:27
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.87%. Comparing base (a46728e) to head (b142a02).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1664   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files         282      282           
  Lines       15601    15601           
=======================================
  Hits        14801    14801           
  Misses        630      630           
  Partials      170      170           
Flag Coverage Δ
unittests 94.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewpearce-digital andrewpearce-digital merged commit 7816fa0 into main Dec 5, 2024
31 checks passed
@andrewpearce-digital andrewpearce-digital deleted the MLPAB-2740-implement-v-0-2-6-of-the-firewalled-network branch December 5, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants