MLPAB-2018 Add scheduled events to remind certificate provider #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawx
force-pushed
the
MLPAB-2018-reminder-certificate-provider
branch
from
bd173fd to
bd9a2b1
Compare
hawx
force-pushed
the
MLPAB-2018-reminder-certificate-provider
branch
from
bd9a2b1 to
4057f5e
Compare
hawx
force-pushed
the
MLPAB-2018-reminder-certificate-provider
branch
from
4057f5e to
41356b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1683 +/- ##
==========================================
+ Coverage 94.88% 94.97% +0.08%
==========================================
Files 281 284 +3
Lines 15653 15910 +257
==========================================
+ Hits 14853 15110 +257
Misses 630 630
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hawx
force-pushed
the
MLPAB-2018-reminder-certificate-provider
branch
from
41356b7 to
dda3b49
Compare
hawx
force-pushed
the
MLPAB-2018-reminder-certificate-provider
branch
from
dda3b49 to
76e9c4e
Compare
hawx
force-pushed
the
MLPAB-2018-reminder-certificate-provider
branch
from
76e9c4e to
c893fe6
Compare
hawx
force-pushed
the
MLPAB-2018-reminder-certificate-provider
branch
2 times, most recently
from
122e78e to
449caff
Compare
hawx
force-pushed
the
MLPAB-2018-reminder-certificate-provider
branch
from
449caff to
4304f0d
Compare
hawx
force-pushed
the
MLPAB-2018-reminder-certificate-provider
branch
from
4304f0d to
8d22577
Compare
hawx
force-pushed
the
MLPAB-2018-reminder-certificate-provider
branch
from
8d22577 to
5538fe9
Compare
hawx
force-pushed
the
MLPAB-2018-reminder-certificate-provider
branch
from
5538fe9 to
108aa0c
Compare
hawx
force-pushed
the
MLPAB-2018-reminder-certificate-provider
branch
from
108aa0c to
fd19741
Compare
hawx
force-pushed
the
MLPAB-2018-reminder-certificate-provider
branch
from
fd19741 to
2285214
Compare
acsauk
reviewed
Dec 17, 2024
| return fmt.Errorf("error sending sharecode to attorneys: %w", err) | ||
| } | ||
|
|
||
| if !certificateProvider.Tasks.ConfirmYourDetails.IsCompleted() { |
There was a problem hiding this comment.
Should this be:
Suggested change
| if !certificateProvider.Tasks.ConfirmYourDetails.IsCompleted() { | |
| if !certificateProvider.Tasks.ConfirmYourIdentity.IsCompleted() { |
hawx
force-pushed
the
MLPAB-2018-reminder-certificate-provider
branch
from
2285214 to
407814a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because when the scheduled event should occur can change I'm going for the approach of setting multiple scheduled events, then checking if it is valid to run or should be ignored. This is safe as expiry can only go up (from 6 months to 24), so in that case we'd be ignoring the event at +3 months.