Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-1353 - Trigger a tfsec Pr comment #676

Merged

Conversation

andrewpearce-digital
Copy link
Contributor

@andrewpearce-digital andrewpearce-digital commented Aug 31, 2023

Purpose

The TFSec PR commenter action has been ignoring findings and not adding them to PRs

Fixes MLPAB-1353

Approach

  • remove matrix strategy
  • set an empty working directory to make tfsec check all terraform files in the repo

Learning

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

PR Environment Terraform Plan Summary

No changes. Your infrastructure matches the configuration.

@andrewpearce-digital andrewpearce-digital temporarily deployed to dev_676mlpab135 August 31, 2023 16:33 — with GitHub Actions Inactive
protocol = "-1"
from_port = 0
to_port = 0
cidr_blocks = ["0.0.0.0/0"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ tfsec found a CRITICAL severity issue from rule aws-ec2-no-public-egress-sgr:

Security group rule allows egress to multiple public internet addresses.

More information available here and here

protocol = "-1"
from_port = 0
to_port = 0
cidr_blocks = ["0.0.0.0/0"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ tfsec found a CRITICAL severity issue from rule aws-ec2-no-public-egress-sgr:

Security group rule allows egress to multiple public internet addresses.

More information available here and here

protocol = "-1"
from_port = 0
to_port = 0
cidr_blocks = ["0.0.0.0/0"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ tfsec found a CRITICAL severity issue from rule aws-ec2-no-public-egress-sgr:

Security group rule allows egress to multiple public internet addresses.

More information available here and here

protocol = "-1"
from_port = 0
to_port = 0
cidr_blocks = ["0.0.0.0/0"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ tfsec found a CRITICAL severity issue from rule aws-ec2-no-public-egress-sgr:

Security group rule allows egress to multiple public internet addresses.

More information available here and here

protocol = "-1"
from_port = 0
to_port = 0
cidr_blocks = ["0.0.0.0/0"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ tfsec found a CRITICAL severity issue from rule aws-ec2-no-public-egress-sgr:

Security group rule allows egress to multiple public internet addresses.

More information available here and here

@andrewpearce-digital andrewpearce-digital temporarily deployed to dev_676mlpab135 August 31, 2023 17:02 — with GitHub Actions Inactive
@andrewpearce-digital andrewpearce-digital marked this pull request as ready for review August 31, 2023 17:04
@andrewpearce-digital andrewpearce-digital requested a review from a team as a code owner August 31, 2023 17:05
@andrewpearce-digital andrewpearce-digital merged commit c15c393 into main Sep 1, 2023
@andrewpearce-digital andrewpearce-digital deleted the MLPAB-1353-t-fsec-pr-comments-arent-working branch September 1, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants