Cleaner init of tests + bug fix #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of starting tests cleaner
jamesgreen-moj
requested review from
staff-infrastructure-moj,
juddin927 and
asifamirat00
smjmoj
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed unclean init of tests within make file, and made the process of starting tests cleaner.
A combination of "depends on" and the way the make file calls the tests to run.I noted when containerd was enabled. It would kill and restart the staff-device-dhcp-server-dhcp-primary-1 when it gets to this line "$(DOCKER_COMPOSE) run --rm dhcp-test rspec -f d ./spec" in the make fileSo by commenting out the depends on, it would no longer kill and restart the staff-device-dhcp-server-dhcp-primary-1 container thus not affecting the tests.