Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdef and template quick fix and test file #31

Merged
merged 2 commits into from
Nov 30, 2021
Merged

pdef and template quick fix and test file #31

merged 2 commits into from
Nov 30, 2021

Conversation

singledoggy
Copy link

I make a quick fix:
here
add some test files:
test8_5.ctl
test8_6.ctl

Change of the empty line is the default setting of my ide, it can avoid many bugs.

By the way, would you mind to change your code to PEP8? There are many tools and can make your code more beautiful.

@singledoggy singledoggy changed the title pdef and template quick fix and test file pdef and template quick fix and test file Fixes miniufo/xgrads/issues/30 Nov 27, 2021
@singledoggy singledoggy changed the title pdef and template quick fix and test file Fixes miniufo/xgrads/issues/30 pdef and template quick fix and test file Fixes miniufo/xgrads/issues/#30 Nov 27, 2021
@singledoggy singledoggy changed the title pdef and template quick fix and test file Fixes miniufo/xgrads/issues/#30 pdef and template quick fix and test file Nov 27, 2021
@singledoggy singledoggy changed the title pdef and template quick fix and test file pdef and template quick fix and test file#30 Nov 27, 2021
@singledoggy singledoggy changed the title pdef and template quick fix and test file#30 pdef and template quick fix and test file Nov 27, 2021
@singledoggy
Copy link
Author

Closes #30

@miniufo
Copy link
Owner

miniufo commented Nov 29, 2021

I see there shoud be an 'if pdef is None'. Thanks for you quick solution. I'll give a test run later.
BTW, what's your IDE? Spyder or VS code?
I am not sure if PEP8 is more elegant but thanks for your remind. I have some kind of coding '强迫症', but this (following PEP8) is not one of them. ∩_∩

@miniufo
Copy link
Owner

miniufo commented Nov 30, 2021

Could you send me some small chunks of binary data so I can give a try with the data? Only ctls are not enough for a test.

@singledoggy
Copy link
Author

singledoggy commented Nov 30, 2021

Actually PDF only influence the projection information, it's in someway independent, so I guess you can use your data in your test dataset, like test8_5.ctl and test8_6.ctl.

IDK how to generate a smalll chunk, I have a set of file each size is 339.8 MB and I need to ask my boss if I can share it. Do you need the large file? If so I'll ask him anyway.

I use spyder and sometimes vim+vim-plug: python mode. I don't remember which change the default indentation format.

AND THANKS FOR YOUR EXCELLENT WORK!

@miniufo miniufo merged commit 5cb470a into miniufo:master Nov 30, 2021
@miniufo
Copy link
Owner

miniufo commented Nov 30, 2021

Hi, I did not notice these two ctls are based on my examples. Now I merge your PR. Thank you for your contribution to the package!!!

@miniufo miniufo added the bug Something isn't working label May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants