-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdef and template quick fix and test file #31
Conversation
Closes #30 |
I see there shoud be an 'if pdef is None'. Thanks for you quick solution. I'll give a test run later. |
Could you send me some small chunks of binary data so I can give a try with the data? Only ctls are not enough for a test. |
Actually PDF only influence the projection information, it's in someway independent, so I guess you can use your data in your test dataset, like test8_5.ctl and test8_6.ctl. IDK how to generate a smalll chunk, I have a set of file each size is 339.8 MB and I need to ask my boss if I can share it. Do you need the large file? If so I'll ask him anyway. I use spyder and sometimes vim+vim-plug: python mode. I don't remember which change the default indentation format. AND THANKS FOR YOUR EXCELLENT WORK! |
Hi, I did not notice these two ctls are based on my examples. Now I merge your PR. Thank you for your contribution to the package!!! |
I make a quick fix:
here
add some test files:
test8_5.ctl
test8_6.ctl
Change of the empty line is the default setting of my ide, it can avoid many bugs.
By the way, would you mind to change your code to
PEP8
? There are many tools and can make your code more beautiful.