Merge pull request #96 from minkan-chat/fixes/95

fix: remove `PartialEq` implementation from `JsonWebKey`
minkan-chat · Jan 22, 2025 · edff67a · edff67a
2 parents b28f8bf + 1065c08
commit edff67a
Show file tree

Hide file tree

Showing 11 changed files with 332 additions and 147 deletions.
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -48,11 +48,7 @@ jobs:
           toolchain: ${{ matrix.toolchain }}
           components: clippy
       - name: cargo clippy
-        uses: actions-rs/clippy-check@v1
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
-          args: --all-features -- -D warnings
-
+        run: cargo clippy --all-features -- -D warnings
   doc:
     runs-on: ubuntu-latest
     name: nightly / doc
@@ -81,7 +77,7 @@ jobs:
         with:
           submodules: true
       - name: cargo-deny
-        uses: EmbarkStudios/cargo-deny-action@v1
+        uses: EmbarkStudios/cargo-deny-action@v2
         with:
           command: check ${{ matrix.checks }}
 
@@ -106,7 +102,7 @@ jobs:
     # https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
     strategy:
       matrix:
-        msrv: ["1.65"]
+        msrv: ["1.84"]
     name: ubuntu / ${{ matrix.msrv }}
     steps:
       - uses: actions/checkout@v4

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -32,24 +32,25 @@ jobs:
       # https://github.com/rust-lang/cargo/issues/6669
       - name: cargo test --doc
         run: cargo test --locked --all-features --doc
-
-  minimal:
-    runs-on: ubuntu-latest
-    name: ubuntu / stable / minimal-versions
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          submodules: true
-      - name: Install stable
-        uses: dtolnay/rust-toolchain@stable
-      - name: Install nightly for -Zminimal-versions
-        uses: dtolnay/rust-toolchain@nightly
-      - name: rustup default stable
-        run: rustup default stable
-      - name: cargo update -Zminimal-versions
-        run: cargo +nightly update -Zminimal-versions
-      - name: cargo test
-        run: cargo test --locked --all-features --all-targets
+  # FIXME: enable again after memchr use in serde-json is fixed -> serde-json 
+  # needs to correctly pin memchr
+  # minimal:
+  #   runs-on: ubuntu-latest
+  #   name: ubuntu / stable / minimal-versions
+  #   steps:
+  #     - uses: actions/checkout@v4
+  #       with:
+  #         submodules: true
+  #     - name: Install stable
+  #       uses: dtolnay/rust-toolchain@stable
+  #     - name: Install nightly for -Zminimal-versions
+  #       uses: dtolnay/rust-toolchain@nightly
+  #     - name: rustup default stable
+  #       run: rustup default stable
+  #     - name: cargo update -Zminimal-versions
+  #       run: cargo +nightly update -Zminimal-versions
+  #     - name: cargo test
+  #       run: cargo test --locked --all-features --all-targets
 
   os-check:
     runs-on: ${{ matrix.os }}