Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove PartialEq implementation from JsonWebKey #96

Merged
merged 12 commits into from
Jan 22, 2025
Merged

fix: remove PartialEq implementation from JsonWebKey #96

merged 12 commits into from
Jan 22, 2025

Conversation

Erik1000
Copy link
Member

@Erik1000 Erik1000 commented Apr 4, 2024

fixes #95

@Erik1000 Erik1000 enabled auto-merge April 4, 2024 18:51
@Erik1000 Erik1000 requested a review from Stupremee April 4, 2024 18:51
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.0%. Comparing base (b28f8bf) to head (1065c08).
Report is 13 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
src/jwk.rs 44.4% <ø> (-0.4%) ⬇️
src/jwk/okp.rs 0.0% <ø> (ø)
src/tagged_visitor.rs 71.7% <ø> (ø)
src/uri.rs 0.0% <ø> (ø)

... and 15 files with indirect coverage changes

@Erik1000 Erik1000 added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit edff67a Jan 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stupremee Stupremee Stupremee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When should a JsonWebKey be considered equal to another?
2 participants
@Erik1000 @Stupremee