Remove usage of onNotSuccessfulTest to mark tests as skipped #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 9, 2023
Tests are not marked as skipped automatically anymore when an UnsupportedDriverActionException is caught. Instead, drivers should configure their unsupported tests properly in their testsuite config. PHPUnit 10 removed support for changing the test outcome in the onNotSuccessfulTest method of the TestCase so the previous solution will not work anymore in the future.
stof
force-pushed
the
remove_automatic_skipping
branch
from
4941f5b to
8f0c6d0
Compare
acoulton
pushed a commit
to ingenerator/chrome-mink-driver
that referenced
this pull request
Sep 30, 2024
Refs minkphp/driver-testsuite#65 Refs behat-chrome/chrome-mink-driver#143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are not marked as skipped automatically anymore when an UnsupportedDriverActionException is caught. Instead, drivers should configure their unsupported tests properly in their testsuite config. PHPUnit 10 removed support for changing the test outcome in the onNotSuccessfulTest method of the TestCase so the previous solution will not work anymore in the future.
TODO: update all drivers to add the proper skipped tests in their config