-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve readme #19
base: main
Are you sure you want to change the base?
Improve readme #19
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=========================================
Coverage 81.76% 81.76%
Complexity 191 191
=========================================
Files 1 1
Lines 488 488
=========================================
Hits 399 399
Misses 89 89 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Christophe Coevoet <stof@notk.org>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
We could copy it from the Testing section (maybe with a sentence mentioning that you could also run the browser-specific driver directly instead of Selenium depending on your use case) |
Co-authored-by: Christophe Coevoet <stof@notk.org>
@uuf6429 , could you please remind me where the sample |
@aik099 it feels more like it should be in the documentation somewhere. If we did put it in the repo, it would probably be lost (export-ignore'd), so devs wouldn't find it anyway. |
MinkExtension has a |
It's the first time I see that - totally wasn't aware of it. The last change there is 7 years ago, by the way (that said it looks very useful, just maybe not very visible). |
```shell | ||
composer require --dev "behat/behat" "behat/mink" "friends-of-behat/mink-extension" "mink/webdriver-classic-driver" | ||
``` | ||
2. Configure Behat to enable the Mink Extension and set it to use this driver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would posting a link on https://github.com/FriendsOfBehat/MinkExtension/blob/master/doc/index.rst page, that will explain how to connect this driver specifically to Behat hurt?
// cc @stof .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good idea.
Fixes #4.