Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping custom tests (copy/paste from "driver-testsuite") #47

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Nov 11, 2024

The problem found during the #38 development.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (61b12d0) to head (b00d3f1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #47   +/-   ##
=========================================
  Coverage     84.61%   84.61%           
  Complexity      194      194           
=========================================
  Files             1        1           
  Lines           494      494           
=========================================
  Hits            418      418           
  Misses           76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@uuf6429 uuf6429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things.

tests/Custom/TestCase.php Outdated Show resolved Hide resolved
tests/Custom/TestCase.php Outdated Show resolved Hide resolved
aik099 added a commit that referenced this pull request Nov 12, 2024
Copy link
Member Author

@aik099 aik099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've corrected both things.

tests/Custom/TestCase.php Outdated Show resolved Hide resolved
tests/Custom/TestCase.php Outdated Show resolved Hide resolved
@aik099 aik099 force-pushed the allow-skipping-custom-driver-tests branch from 22e332e to b00d3f1 Compare November 12, 2024 05:31
@uuf6429 uuf6429 merged commit 8e3c6ca into minkphp:main Nov 12, 2024
16 of 17 checks passed
@uuf6429 uuf6429 requested review from uuf6429 and removed request for uuf6429 November 12, 2024 07:51
@aik099 aik099 deleted the allow-skipping-custom-driver-tests branch November 12, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants