Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the email mechanisms to work in the development environment #204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhsu802701
Copy link
Contributor

The change in src/config/environments/development.rb in this pull request allows you to use the password reset feature in the local development environment.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.482% when pulling d049f83 on jhsu802701:pr_password_reset_dev into a454e3d on minnestar:master.

Copy link
Member

@caseyhelbling caseyhelbling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first two lines look good but I've got a question about the 1025 port.

# BEGIN: needed for email confirmations
config.action_mailer.default_url_options = { host: 'localhost', port: 3000 }
config.action_mailer.delivery_method = :smtp
config.action_mailer.smtp_settings = { address: 'localhost', port: 1025 }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't the SMTP server run on port 25? (Specifically, if this is running in a virtual env I think everything should run on stock default ports.) Or, maybe there is something about smtp servers running on port 1025 that I'm missing?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants