327 adds docker compose setup w postgres #328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…als, adds X qualifier to twitter, marks all optional
|
Can attest that this worked beautifully. Just had to run |
jcoyne
requested changes
Feb 21, 2025
| @@ -0,0 +1,34 @@ | |||
| version: '3.9' | |||
There was a problem hiding this comment.
I'm pretty sure "version" is obsolete and can be removed. Additionally, the new idiom is to call this file compose.yaml. Would you mind making that change?
|
|
||
| services: | ||
| db: | ||
| image: postgres:15 |
There was a problem hiding this comment.
Is there a reason for 15 rather than 16 or 17?
|
Can you remove 27bec45 from this PR and make it just docker compose? |
|
As long as somebody’s actually using the feature, seems like a good idea. This PR also seems to include a commit from the social media feature? May need a rebase + force push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #327