Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testresample.c output span; add exit code #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix testresample.c output span; add exit code #7

wants to merge 1 commit into from

Commits on Nov 28, 2023

  1. Fix testresample.c output span; add exit code 

    Prior to this chance, the "Resample with different factors" test only
passed for 60 of the 63 factors, with the 3 failing ones being the
largest.

1. Since only 63 distinct factors were being considered, 100 random
   samples was overkill.
2. To support noticing failure in continuous build systems, it's nice if
   the test exit()s with nonzero when there are failures.
3. The root cause was a formula error when determining which indices in
   the resampled output ought be compared. Details are explained in a
   comment.
    @matt-har-vey
    matt-har-vey committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    fb8e3c7 View commit details
    Browse the repository at this point in the history