Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotespace filter that adds a thinspace between adjacent quotation marks #3

Closed
wants to merge 5 commits into from

Conversation

egh
Copy link

@egh egh commented Aug 6, 2012

This filter adds a thinspace (U+2009) between adjacent quotation marks, e.g "' -> " '.

egh added 2 commits August 5, 2012 15:54
Add _mk_unicode_re method to more easily expand unicode characters into possible HTML entities.
@egh
Copy link
Author

egh commented Aug 9, 2012

Thanks for the comment. I've added some doctests. I also added a _mk_unicode_re method that explodes a unicode character (e.g. U+2019) into a re (e.g. "\u2019|’|’|’") to make those regular expressions a little easier.

@Chimrod
Copy link

Chimrod commented Apr 25, 2013

Hello egh,

I've made something similar for my own blog, with french rules typographics.

Note that U+202F is not correctly suported by all browers, and I used nowrap attribute with   instead.
I took a look in your code and saw I've did something similar by extracting some code for amp
I'm using locale for seeing if I need to apply my substitution or not.

pull request : #5

@chrisdrackett
Copy link
Collaborator

@egh We've done a lot of work to revive and update the project recently and this pull request is now pretty out of date. If you would like to submit a new request we would be happy to review it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants