Move chainstate storage init inside constructor #1118
Conversation
azarovh
requested review from
muursh,
erubboli,
iljakuklic and
TheQuantumPhysicist
as code owners
There was a problem hiding this comment.
This looks fine. Though just a question out of carefulness: I remember we deleting only the database directory. Please confirm that's the case, and that we're not deleting the whole data directory. This is because a user setting a wrong data directory could cause a disaster if a wildcard is used.
yes we are removing only that. So in case chainstate is configured with LMDB |
azarovh
force-pushed
the
fix/storage_version_check_mut
branch
from
0e67fa8 to
552e5da
Compare
| use serialization::{Decode, Encode}; | ||
|
|
||
| #[derive(Debug, Encode, Decode, Clone, Copy, Eq, PartialEq)] | ||
| pub struct ChainstateStorageVersion(u32); |
There was a problem hiding this comment.
I've seen many discussions here about what to do about this... and I just want to point out that if we want to make it perfect, we can put all the information (version, magic bytes and net type) in one struct. But I don't really care that much. I'm OK with the way things are now as long as it doesn't lead to a crash and the worst thing that can happen is a wipe and resync.
This is a fix for previous review #1098: