subsystem: Remove custom event loop support #1256

iljakuklic · 2023-10-03T16:51:22Z

Generalized the built-in event loop with
- Custom initialization
- Separation between subsystem state object and interface
- Ability to specify background work in the Subsystem trait
Ported p2p to the built-in event loop
Ported tests to the built-in event loop
Removed support for custom event loop from subsystem
Substantial subsystem crate code reorganization

TheQuantumPhysicist

Looking good. Great work!

mempool/src/interface/mempool_interface_impl.rs

rpc/examples/simple_server.rs

subsystem/src/calls/handle.rs

subsystem/src/manager/mod.rs

subsystem/tests/basic.rs

subsystem/src/calls/handle.rs

muursh

I'm alright with this

subsystem/src/manager/manager_impl.rs

* Generalized the built-in event loop with * Custom initialization * Separation between subsystem state object and interface * Ability to specify background work in the `Subsystem` trait * Ported `p2p` to the built-in event loop * Ported tests to the built-in event loop * Removed support for custom event loop from subsystem * Substantial `subsystem` crate code reorganization

Change signal handlers (Ctrl-C / SIGTERM) to be plain futures rather than something that runs on a separate task. Yields simpler code.

iljakuklic requested review from alfiedotwtf, OBorce, TheQuantumPhysicist and azarovh October 3, 2023 16:51

iljakuklic requested review from muursh and erubboli as code owners October 3, 2023 16:51

iljakuklic added this to the Mainnet milestone Oct 3, 2023

iljakuklic linked an issue Oct 3, 2023 that may be closed by this pull request

Take advantage of the separation between mutable and immutable subsystem calls #131

Closed

iljakuklic force-pushed the subsystem-init branch from 788b1ba to 682b0a5 Compare October 4, 2023 09:19

TheQuantumPhysicist approved these changes Oct 4, 2023

View reviewed changes