Feature/wallet token supply change #1272

OBorce · 2023-10-13T11:33:14Z

Add support for the v1 tokens in the Wallet

track the total supply of the issued tokens
add new commands for mint/unmint of tokens and locking the token supply
existing issue token command now issues the v1 tokens and has an extra argument for token supply
ignore all v0 tokens, they are filtered out in all operations, e.g. not show up in getbalance
new tests

closes #1237

TheQuantumPhysicist · 2023-10-16T22:48:25Z

Does this fix #1237?

OBorce · 2023-10-16T22:56:54Z

Does this fix #1237?

Yes, updated the description.

test/functional/wallet_tokens_change_supply.py

TheQuantumPhysicist · 2023-10-17T17:36:23Z

wallet/wallet-controller/src/synced_controller.rs

+        self.broadcast_to_mempool(tx).await
+    }
+
+    pub async fn lock_tokens(&mut self, token_id: TokenId) -> Result<(), ControllerError<T>> {


Please call this function and all its dependents "lock_tokens_supply". The phrase "lock_tokens" is very ambiguous.

TheQuantumPhysicist · 2023-10-17T17:48:09Z

wallet/wallet-cli-lib/src/commands/helper_types.rs

+    PerThousand::from_decimal_str(value_str).ok_or(WalletCliError::InvalidInput(format!(
+        "Failed to parse {variable_name} the decimal that must be in the range [0.001,1.000] or [0.1%,100%]",


"Failed to parse {variable_name}. The decimal must be in the range..."

TheQuantumPhysicist · 2023-10-17T18:35:46Z

test/functional/wallet_tokens_change_supply.py

+            self.generate_block()
+            assert_in("Success", await wallet.sync())
+
+            tokens_to_mint = 10000


Can we randomize this test? I'm OK with making another copy that would do the randomization.

specified the --randomseed for the functional tests, and randomized 10 mints/unimts with random amounts

TheQuantumPhysicist · 2023-10-17T18:35:58Z

Looking good, besides the comments!

wallet/src/account/output_cache/mod.rs

wallet/types/src/utxo_types.rs

wallet/wallet-cli-lib/src/commands/mod.rs

azarovh · 2023-10-19T07:43:46Z

btw there is one more piece of commented code in the test/functional/wallet_nfts.py

TheQuantumPhysicist · 2023-10-24T10:17:12Z

test/functional/test_framework/wallet_cli_controller.py

+        return await self._write_command(f"unminttokens {token_id} {amount}\n")
+
+    async def lock_token_suply(self, token_id: str) -> str:
+        return await self._write_command(f"locktokensuply {token_id}\n")


TheQuantumPhysicist · 2023-10-24T10:55:02Z

wallet/src/wallet/tests.rs

+#[case(Seed::from_entropy())]
+fn check_tokens_v0_are_ignored(#[case] seed: Seed) {
+    let mut rng = make_seedable_rng(seed);
+    let chain_config = Arc::new(create_mainnet());


Is there a reason why we're using mainnet here? Just understand that this config can change in the future when creating mainnet.

no particular reason, I will change it

TheQuantumPhysicist · 2023-10-24T11:09:29Z

minor things I mentioned, all good! Let's merge this today.

lock_tokens -> lock_token_supply specify a randomseed argument for the functional tests randomize token supply change test

- remove unused amount_to_issue argument for the new issue totkens command - rename TokenTotalSupplyState to TokenCurrentSupplyState

OBorce force-pushed the feature/wallet-token-supply-change branch 2 times, most recently from e0f449f to 29f1a3c Compare October 13, 2023 17:29

azarovh mentioned this pull request Oct 15, 2023

Change tokens supply #1179

Merged

OBorce marked this pull request as ready for review October 16, 2023 17:54

OBorce requested review from muursh, erubboli, iljakuklic, TheQuantumPhysicist and azarovh as code owners October 16, 2023 17:54

OBorce force-pushed the feature/wallet-token-supply-change branch from b2c63c7 to b085273 Compare October 16, 2023 18:01

TheQuantumPhysicist reviewed Oct 17, 2023

View reviewed changes

test/functional/wallet_tokens_change_supply.py Outdated Show resolved Hide resolved

TheQuantumPhysicist reviewed Oct 17, 2023

View reviewed changes

OBorce force-pushed the feature/wallet-token-supply-change branch 2 times, most recently from 85de415 to 2456eb9 Compare October 18, 2023 16:44

azarovh approved these changes Oct 18, 2023

View reviewed changes

OBorce marked this pull request as draft October 18, 2023 18:01

OBorce marked this pull request as ready for review October 18, 2023 21:26

OBorce marked this pull request as draft October 19, 2023 09:32

OBorce force-pushed the feature/wallet-token-supply-change branch from 3d39e5f to 734e2de Compare October 19, 2023 12:25

OBorce marked this pull request as ready for review October 19, 2023 14:21

azarovh force-pushed the feat/increase_tokens_supply branch 2 times, most recently from 9768935 to 6cd5f00 Compare October 23, 2023 13:46

Base automatically changed from feat/increase_tokens_supply to master October 23, 2023 20:27

OBorce force-pushed the feature/wallet-token-supply-change branch from 734e2de to a6fe57e Compare October 23, 2023 22:38

TheQuantumPhysicist reviewed Oct 24, 2023

View reviewed changes

TheQuantumPhysicist approved these changes Oct 24, 2023

View reviewed changes

OBorce force-pushed the feature/wallet-token-supply-change branch from a6fe57e to ee55e7e Compare October 24, 2023 11:32

OBorce added 11 commits October 24, 2023 14:10

Keep track of token supply in the wallet cache

5d31cfa

Add change token supply commands to wallet CLI

679d0ee

Fix and add tests for change token supply in the wallet

2b000d4

Fix tests

1cc904a

Rename redeem to unmint

7bcb07c

Add more tests for tokens in the wallet

8d93248

Rename lock tokens and add randomness to functional test

429ebf0

lock_tokens -> lock_token_supply specify a randomseed argument for the functional tests randomize token supply change test

Remove unused command argument

d8a8e50

- remove unused amount_to_issue argument for the new issue totkens command - rename TokenTotalSupplyState to TokenCurrentSupplyState

Fix query token data for NFT issuance v1

0866470

Uncomment NFT wallet functional test

b530f83

Fix typos

8d0d1b3

OBorce force-pushed the feature/wallet-token-supply-change branch from 602b4aa to 8d0d1b3 Compare October 24, 2023 12:14

OBorce merged commit f879707 into master Oct 24, 2023

OBorce deleted the feature/wallet-token-supply-change branch October 24, 2023 15:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/wallet token supply change #1272

Feature/wallet token supply change #1272

OBorce commented Oct 13, 2023 •

edited

Loading

TheQuantumPhysicist commented Oct 16, 2023

OBorce commented Oct 16, 2023

TheQuantumPhysicist Oct 17, 2023

OBorce Oct 18, 2023

TheQuantumPhysicist Oct 17, 2023

OBorce Oct 18, 2023

TheQuantumPhysicist Oct 17, 2023

OBorce Oct 18, 2023

TheQuantumPhysicist commented Oct 17, 2023

azarovh commented Oct 19, 2023

TheQuantumPhysicist Oct 24, 2023

OBorce Oct 24, 2023

TheQuantumPhysicist Oct 24, 2023 •

edited

Loading

OBorce Oct 24, 2023

TheQuantumPhysicist commented Oct 24, 2023

		PerThousand::from_decimal_str(value_str).ok_or(WalletCliError::InvalidInput(format!(
		"Failed to parse {variable_name} the decimal that must be in the range [0.001,1.000] or [0.1%,100%]",

Feature/wallet token supply change #1272

Feature/wallet token supply change #1272

Conversation

OBorce commented Oct 13, 2023 • edited Loading

TheQuantumPhysicist commented Oct 16, 2023

OBorce commented Oct 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TheQuantumPhysicist commented Oct 17, 2023

azarovh commented Oct 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TheQuantumPhysicist Oct 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TheQuantumPhysicist commented Oct 24, 2023

OBorce commented Oct 13, 2023 •

edited

Loading

TheQuantumPhysicist Oct 24, 2023 •

edited

Loading