Only ascii alphanumeric strings in tokens after v1 #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovh
requested review from
muursh,
erubboli,
iljakuklic and
TheQuantumPhysicist
as code owners
TheQuantumPhysicist
approved these changes
Oct 19, 2023
iljakuklic
reviewed
Oct 20, 2023
ImplOfAnImpl
approved these changes
Oct 20, 2023
azarovh
force-pushed
the
feat/increase_tokens_supply
branch
from
6bcfada to
442debb
Compare
azarovh
force-pushed
the
fix/tokens_ascii_alphanumeric
branch
from
e061194 to
0a4b7a4
Compare
|
Please don't merge this until I slap another approval. I still have to review it again. I have some doubts. |
TheQuantumPhysicist
suggested changes
Oct 21, 2023
azarovh
force-pushed
the
feat/increase_tokens_supply
branch
from
9768935 to
6cd5f00
Compare
azarovh
force-pushed
the
fix/tokens_ascii_alphanumeric
branch
from
0a4b7a4 to
4604434
Compare
| let current_height = self | ||
| .get_gen_block_index(&prev_block_id)? | ||
| .ok_or(CheckBlockTransactionsError::PropertyQueryError( | ||
| PropertyQueryError::BlockIndexNotFound(prev_block_id), |
There was a problem hiding this comment.
Better use the error PrevBlockIndexNotFound. Also, this is not a nonchalante error... this is an invariant broken.
Why not use the function that was made for this anyway? get_previous_block_index_for_check_block()
There was a problem hiding this comment.
Better use the error PrevBlockIndexNotFound.
Agree, done.
Why not use the function that was made for this anyway?
It returns incompatible Error type. It doesn't do much so I think it's ok to leave it like this.
TheQuantumPhysicist
approved these changes
Oct 24, 2023
azarovh
force-pushed
the
fix/tokens_ascii_alphanumeric
branch
from
4604434 to
d6b167f
Compare
muursh
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.