Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial Address balance endpoint support to the API Server #1293

Merged
merged 19 commits into from
Nov 1, 2023
Merged

Add initial Address balance endpoint support to the API Server #1293

merged 19 commits into from
Nov 1, 2023

Conversation

alfiedotwtf
Copy link
Contributor

Part of #1189

@alfiedotwtf alfiedotwtf mentioned this pull request Oct 26, 2023
Closed
@alfiedotwtf alfiedotwtf force-pushed the alfie/address-balance branch from e2a72dc to 76bddbd Compare October 27, 2023 11:12
@alfiedotwtf alfiedotwtf marked this pull request as ready for review October 27, 2023 12:17
@alfiedotwtf alfiedotwtf force-pushed the alfie/address-balance branch from 137dc10 to a77a4fa Compare October 30, 2023 06:24
TheQuantumPhysicist
TheQuantumPhysicist approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@TheQuantumPhysicist TheQuantumPhysicist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the minor comment, I think this is fine.

Please wait until we finish the token work we're doing to merge. I don't want to cause conflicts.

@alfiedotwtf alfiedotwtf mentioned this pull request Oct 31, 2023
Merged
@alfiedotwtf alfiedotwtf marked this pull request as draft November 1, 2023 02:33
@alfiedotwtf alfiedotwtf marked this pull request as ready for review November 1, 2023 06:08
@TheQuantumPhysicist TheQuantumPhysicist merged commit 9180a2a into master Nov 1, 2023
@TheQuantumPhysicist TheQuantumPhysicist deleted the alfie/address-balance branch November 1, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheQuantumPhysicist TheQuantumPhysicist TheQuantumPhysicist approved these changes

@muursh muursh Awaiting requested review from muursh

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

@iljakuklic iljakuklic Awaiting requested review from iljakuklic

@azarovh azarovh Awaiting requested review from azarovh azarovh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfiedotwtf @TheQuantumPhysicist