Remove the transaction index and all its traces #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheQuantumPhysicist
requested review from
muursh,
erubboli,
iljakuklic and
azarovh
as code owners
azarovh
approved these changes
Oct 27, 2023
azarovh
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
The only comment I have is that you also need to go through tests in wrong tabchainstate/tx-verifier/src/transaction_verifier/input_output_policy/tests/purpose_tests.rs and place deposit output among invalid cases because we don't have compile time guard there and it has to be done manually.
alfiedotwtf
reviewed
Oct 27, 2023
alfiedotwtf
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the research we done, all the features of the transaction index can be done through the API server. Transactions that are interesting to the user should be taken from the wallet. PR #1304 should take care of that.
Closes #1274