Remove the temporary solution that required GTK3 #1310
Merged
+494
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheQuantumPhysicist
requested review from
muursh,
erubboli,
iljakuklic and
azarovh
as code owners
iljakuklic
approved these changes
Oct 30, 2023
TheQuantumPhysicist
added a commit
that referenced
this pull request
Nov 6, 2023
Revert "Merge pull request #1310 from mintlayer/fix/remove_gtk3"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a regression issue in rust that affected the rfd crate:
PolyMeilex/rfd#126
compilation used to take 10 minutes. But after Rust 1.73, this issue is fixed. Now we can let go of gtk, which simplifies the installation requirements of mintlayer-core a lot.