Feature/wallet token freeze unfreeze #1312

OBorce · 2023-10-28T13:46:48Z

add new commands for freeze and unfreeze tokens
check send/mint/unmint of tokens if they are frozen before creating the transaction
add tests

wallet/src/account/output_cache/mod.rs

wallet/src/wallet/mod.rs

wallet/wallet-controller/src/synced_controller.rs

wallet/src/wallet/tests.rs

TheQuantumPhysicist

Besides the minor comments, looking good.

Please merge this only after all the consensus stuff is merged, followed by a rebase.

- extract common functionality into helper functions

- fix some typos

OBorce requested review from muursh, erubboli, iljakuklic, TheQuantumPhysicist and azarovh as code owners October 28, 2023 13:46

azarovh approved these changes Oct 30, 2023

View reviewed changes

TheQuantumPhysicist reviewed Oct 30, 2023

View reviewed changes

wallet/src/account/output_cache/mod.rs Show resolved Hide resolved

TheQuantumPhysicist reviewed Oct 30, 2023

View reviewed changes

wallet/src/wallet/mod.rs Outdated Show resolved Hide resolved

TheQuantumPhysicist reviewed Oct 30, 2023

View reviewed changes

wallet/wallet-controller/src/synced_controller.rs Outdated Show resolved Hide resolved

TheQuantumPhysicist reviewed Oct 30, 2023

View reviewed changes

wallet/src/wallet/tests.rs Outdated Show resolved Hide resolved

TheQuantumPhysicist approved these changes Oct 30, 2023

View reviewed changes

azarovh force-pushed the feat/freeze_tokens branch 3 times, most recently from c85feff to a7d01ba Compare October 31, 2023 16:19

OBorce force-pushed the feature/wallet-token-freeze-unfreeze branch 3 times, most recently from 9b9f401 to 4ab8d28 Compare October 31, 2023 16:39

OBorce added 6 commits October 31, 2023 17:41

Handle freeze and unfreeze of tokens in the wallet

7694481

Add checks for frozen tokens before using them

9f37c22

Add freeze/unfreeze token commands to the CLI wallet

f1f3c1c

Add tests for freeze and unfreeze of tokens in the wallet

79ba157

Refactor synced controller

c9c4e8d

- extract common functionality into helper functions

Fix frozen and unfrozen fee calculation

68cb481

- fix some typos

OBorce force-pushed the feature/wallet-token-freeze-unfreeze branch from 4ab8d28 to 68cb481 Compare October 31, 2023 16:42

Base automatically changed from feat/freeze_tokens to master October 31, 2023 18:39

TheQuantumPhysicist merged commit 1a8842f into master Oct 31, 2023

TheQuantumPhysicist deleted the feature/wallet-token-freeze-unfreeze branch October 31, 2023 19:47

Provide feedback