Temp fix for issuance and supply change fee in the same tx #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovh
requested review from
muursh,
erubboli,
iljakuklic and
TheQuantumPhysicist
as code owners
azarovh
force-pushed
the
fix/issuance_and_supply_change_fee
branch
from
37ffd5b to
b29a9eb
Compare
|
|
||
| match latest_token_version { | ||
| TokenIssuanceVersion::V0 => { | ||
| check_issuance_fee_burn_v0(chain_config, tx)?; |
There was a problem hiding this comment.
I'm assuming that this will completely die after the fork.
There was a problem hiding this comment.
We will have to keep it in the testnet so that fee for older blocks is calculated correctly. But for the mainnet I hope this whole module will go away.
| @@ -390,6 +432,72 @@ pub fn calculate_tokens_burned_in_outputs( | |||
| .ok_or(ConnectTransactionError::BurnAmountSumError(tx.get_id())) | |||
| } | |||
|
|
|||
| fn calculate_required_fee_burn( | |||
There was a problem hiding this comment.
I don't mind these gymnastics, considering they're temporary... but wouldn't have been easier to just make a copy of the current input calculation method, and add these to it as subtraction to the total?
There was a problem hiding this comment.
Not sure it's rather big, I'd keep it like this
TheQuantumPhysicist
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest this as a temporary fix until I implement this logic via ConstraintsAccumulator.
Doing it the right way via ConstraintsAccumulator turns out a bit more complicated than I thought. Also given the complexity of that solution I'm afraid that by rushing it I introduce more bugs than I fix.