Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow changing authority for a token #1318

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Allow changing authority for a token #1318

merged 5 commits into from
Oct 31, 2023

Conversation

azarovh
Copy link
Member

@azarovh azarovh commented Oct 31, 2023

Allow changing authority for a token

I won't merge it before freezing functionality

@azarovh azarovh added the chainstate Chainstate-related issues label Oct 31, 2023
TheQuantumPhysicist
TheQuantumPhysicist approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@TheQuantumPhysicist TheQuantumPhysicist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, besides the comments, looking good.

All the stuff we added this week has to go through huge scrutiny until the release. We should try to image every way to break the code and make things go wrong.

@azarovh azarovh force-pushed the feat/freeze_tokens branch from c85feff to a7d01ba Compare October 31, 2023 16:19
@azarovh azarovh force-pushed the feat/change_token_authority branch from 0256d78 to f3a0613 Compare October 31, 2023 16:30
Base automatically changed from feat/freeze_tokens to master October 31, 2023 18:39
@TheQuantumPhysicist TheQuantumPhysicist force-pushed the feat/change_token_authority branch from f3a0613 to a43f175 Compare October 31, 2023 20:50
@TheQuantumPhysicist TheQuantumPhysicist merged commit d986449 into master Oct 31, 2023
@TheQuantumPhysicist TheQuantumPhysicist deleted the feat/change_token_authority branch October 31, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheQuantumPhysicist TheQuantumPhysicist TheQuantumPhysicist approved these changes

@iljakuklic iljakuklic iljakuklic approved these changes

@muursh muursh muursh approved these changes

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

Assignees
No one assigned
Labels
chainstate Chainstate-related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azarovh @iljakuklic @muursh @TheQuantumPhysicist