Remove the spuriously failing test "dont_make_announcements_while_blocks_are_being_sent" #1321
+40
−197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I remove the spuriously failing test
dont_make_announcements_while_blocks_are_being_sent
, as well as the changes that were made when trying to fix it.Two reasons for it:
The only alternative to removing the test is to increase the number of initial blocks, so that they take longer time to send. But it slows down the test noticeably and still doesn't guarantee the absence of spurious failures.