Skip to content

Remove the spuriously failing test "dont_make_announcements_while_blocks_are_being_sent" #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

ImplOfAnImpl
Copy link
Contributor

@ImplOfAnImpl ImplOfAnImpl commented Nov 1, 2023

Here I remove the spuriously failing test dont_make_announcements_while_blocks_are_being_sent, as well as the changes that were made when trying to fix it.
Two reasons for it:

  1. The test checks a very minor improvement - the fact that the node should avoid sending header updates to a peer, while the peer is downloading blocks from it.
  2. It turned out to be hard to avoid spurious failures in it - the test block that is supposed not to trigger an update may miss the window where the older blocks are being sent, so the update would actually be triggered.
    The only alternative to removing the test is to increase the number of initial blocks, so that they take longer time to send. But it slows down the test noticeably and still doesn't guarantee the absence of spurious failures.

…ke_announcements_while_blocks_are_being_sent, as well as the changes that were made when trying to fix it.
@TheQuantumPhysicist TheQuantumPhysicist merged commit 175ba96 into master Nov 1, 2023
@TheQuantumPhysicist TheQuantumPhysicist deleted the p2p_remove_spuriously_failing_test branch November 1, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants