Allow single account command in transaction inputs #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
azarovh
commented
Nov 2, 2023
•
azarovh
commented
- Main motivation for this PR is to allow only one authorizable account command per tx inputs. To easily control that I isolated all commands into a separate type so that they can be easily checked for uniqueness.
- Also this PR allows empty outputs in transaction that has input commands because some commands do not produce output (lock supply, freeze, change authority) thus it won't require user to use fake outputs
azarovh
force-pushed
the
feat/tx_input_account_op_arm
branch
2 times, most recently
from
ae85c10 to
3a72063
Compare
azarovh
force-pushed
the
feat/tx_input_account_op_arm
branch
from
3a72063 to
fdcafe2
Compare
azarovh
force-pushed
the
feat/tx_input_account_op_arm
branch
from
fdcafe2 to
51c7182
Compare
azarovh
changed the title
azarovh
changed the title
azarovh
requested review from
muursh,
erubboli,
iljakuklic and
TheQuantumPhysicist
as code owners
Comment on lines
+162
to
+169
| let account_commands_count = tx | ||
| .inputs() | ||
| .iter() | ||
| .filter(|input| match input { | ||
| TxInput::Utxo(_) | TxInput::Account(..) => false, | ||
| TxInput::AccountCommand(..) => true, | ||
| }) | ||
| .count(); |
There was a problem hiding this comment.
Worth it... geez it was a nightmare of complexity.
iljakuklic
approved these changes
Nov 2, 2023
chainstate/tx-verifier/src/transaction_verifier/transferred_amount_check.rs
Show resolved
Hide resolved
TheQuantumPhysicist
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.