Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove access to chainstate database without a transaction #1335

Merged
merged 9 commits into from
Nov 3, 2023
Merged

Remove access to chainstate database without a transaction #1335

merged 9 commits into from
Nov 3, 2023

Conversation

TheQuantumPhysicist
Copy link
Contributor

Less macros, more responsibility.

iljakuklic
iljakuklic reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@iljakuklic iljakuklic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick first pass

@TheQuantumPhysicist
Copy link
Contributor Author

Just a quick first pass

Pushed all fixes to the issues pointed out.

azarovh
azarovh approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@azarovh azarovh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@TheQuantumPhysicist TheQuantumPhysicist merged commit d480a4b into master Nov 3, 2023
@TheQuantumPhysicist TheQuantumPhysicist deleted the fix/remove_non_tx_store_access branch November 3, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iljakuklic iljakuklic iljakuklic approved these changes

@azarovh azarovh azarovh approved these changes

@muursh muursh Awaiting requested review from muursh

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheQuantumPhysicist @iljakuklic @azarovh