Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the node's block height is < wallet height #1344

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Check if the node's block height is < wallet height #1344

merged 1 commit into from
Nov 4, 2023

Conversation

OBorce
Copy link
Contributor

@OBorce OBorce commented Nov 4, 2023 •
edited
Loading

  • prevent an assert from causing a panic in the wallet sync when the node is out of sync
  • Allow the wallet to be opened even when the node is out of sync, but can only issue read commands like getbalance...

@OBorce
Check if the node's block height is < wallet height
55ce424 
- prevent an assert from causing a panic in the wallet sync when the
  node is out of sync
@TheQuantumPhysicist TheQuantumPhysicist merged commit a0a53e5 into master Nov 4, 2023
@TheQuantumPhysicist TheQuantumPhysicist deleted the fix/wallet-panic-on-sync branch November 4, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheQuantumPhysicist TheQuantumPhysicist TheQuantumPhysicist approved these changes

@muursh muursh Awaiting requested review from muursh

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

@iljakuklic iljakuklic Awaiting requested review from iljakuklic

@azarovh azarovh Awaiting requested review from azarovh azarovh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OBorce @TheQuantumPhysicist