Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new ember-resolver instead of ember/resolver #31

Merged
merged 1 commit into from
Dec 3, 2015
Merged

Use new ember-resolver instead of ember/resolver #31

merged 1 commit into from
Dec 3, 2015

Conversation

pichfl
Copy link
Contributor

@pichfl pichfl commented Nov 19, 2015

This should remove the deprecation warning in the latest Ember release v2.2.0.

I only tested against 2.2.0, I will test against the older version later today, I just wanted to file the pull request to make sure I don't forget it later on.

@FredUK
Copy link

FredUK commented Dec 3, 2015

Just updating my Ember app to 1.13.8 and getting rid of all the deprecation warnings and came across this one. When will ember/resolver be replaced to ember-resolver? I really didn't want to fork the repo or use someone else's fork just for this change. Do you know when this will be updated?

@pichfl
Copy link
Contributor Author

pichfl commented Dec 3, 2015

I really don't know. It should be fine to merge this, the build is failing for other reasons though.

I had not yet time to test this for older ember releases and I haven't researched how to make both variants work yet.

@rlivsey
Copy link
Member

rlivsey commented Dec 3, 2015

Failures are unrelated to this so going to merge, I'm seeing similar failures in other addons where the container/owner is not found in tests but works fine in development.

Our flat has just been flooded, so my time to investigate tonight is limited, but will take a look more hopefully over the weekend.

rlivsey added a commit that referenced this pull request Dec 3, 2015
Use new ember-resolver instead of ember/resolver
@rlivsey rlivsey merged commit ba1ee8e into minutebase:master Dec 3, 2015
@FredUK
Copy link

FredUK commented Dec 4, 2015

Sorry to hear that Richard. Thanks a lot for the merge. Hope everything turns out OK with the flat.

@acorncom
Copy link

acorncom commented Dec 4, 2015

Regarding test failures, haven't looked into it thoroughly yet, but there has been a change on how to do lookups that may be related: emberjs/guides#982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants