Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry refactoring #1000

Closed
wants to merge 10 commits into from
Closed

Poetry refactoring #1000

wants to merge 10 commits into from

Conversation

Darwinkel
Copy link
Contributor

@Darwinkel Darwinkel commented May 19, 2023

Changes

Please describe the essence of this PR in a few sentences. Mention any breaking changes or required configuration steps.

Issue link

#735

Proof

Please add some proof of your working change here, unless this is not required (e.g. this PR is trivial).


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

# Conflicts:
#	keiko/poetry.lock
#	keiko/requirements-dev.txt
#	keiko/requirements.txt
#	octopoes/requirements-dev.txt
#	octopoes/requirements.txt
@Darwinkel Darwinkel changed the title Implement Poetry for the root, keiko, and octopoes Poetry refactoring May 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023

File Coverage
All files 65%
bits/definitions.py 65%
bits/runner.py 56%
bits/https_availability/https_availability.py 93%
bits/oois_in_headers/oois_in_headers.py 57%
bits/spf_discovery/internetnl_spf_parser.py 55%
bits/spf_discovery/spf_discovery.py 72%
octopoes/api/api.py 58%
octopoes/api/models.py 75%
octopoes/api/router.py 46%
octopoes/core/app.py 80%
octopoes/core/service.py 44%
octopoes/events/events.py 96%
octopoes/events/manager.py 65%
octopoes/models/__init__.py 86%
octopoes/models/datetime.py 66%
octopoes/models/exception.py 83%
octopoes/models/origin.py 70%
octopoes/models/path.py 99%
octopoes/models/types.py 95%
octopoes/models/ooi/certificate.py 96%
octopoes/models/ooi/config.py 89%
octopoes/models/ooi/email_security.py 95%
octopoes/models/ooi/findings.py 94%
octopoes/models/ooi/network.py 97%
octopoes/models/ooi/service.py 91%
octopoes/models/ooi/software.py 71%
octopoes/models/ooi/web.py 81%
octopoes/models/ooi/dns/records.py 95%
octopoes/models/ooi/dns/zone.py 77%
octopoes/repositories/ooi_repository.py 39%
octopoes/repositories/origin_parameter_repository.py 53%
octopoes/repositories/origin_repository.py 52%
octopoes/repositories/scan_profile_repository.py 45%
octopoes/xtdb/client.py 49%
octopoes/xtdb/query_builder.py 69%
octopoes/xtdb/related_field_generator.py 71%
tests/conftest.py 88%
tests/integration/test_xtdb_client.py 34%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against e567745

@Darwinkel Darwinkel closed this May 23, 2023
@dekkers dekkers deleted the feature/unified-poetry-venv branch August 22, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant