Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved poetry configuration for keiko and octopoes #1186

Merged
merged 23 commits into from
Jun 27, 2023

Conversation

Darwinkel
Copy link
Contributor

@Darwinkel Darwinkel commented Jun 14, 2023

Changes

Improves the pipeline for managing dependencies through poetry. I constrained this PR to refactoring keiko and octopoes, since those modules already use poetry. After this PR, we can roll it out to the other modules.

Also, I removed some of the tooling config from the octopoes/keiko pyproject.toml's as those configs are centrally managed by pre-commit through the root's pyproject.toml, and upgraded some workflows to Python 3.11.

Issue link

Relates to #735 (third attempt :-))

Proof

See CI.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Darwinkel Darwinkel requested a review from a team as a code owner June 14, 2023 14:19
@Darwinkel
Copy link
Contributor Author

Some notes with regards to the feedback from the previous PR's:

@Darwinkel
Copy link
Contributor Author

Darwinkel commented Jun 15, 2023

Ah, interesting. The CI automatically updates point releases. We should probably pin point releases in pyproject.toml to prevent that. Probably also better for dependabot.

@Darwinkel
Copy link
Contributor Author

Ah, interesting. The CI automatically updates point releases. We should probably pin point releases in pyproject.toml to prevent that. Probably also better for dependabot.

The yml linter complains when applying path filtering in the style of */requirements.txt

Fixed!

ammar92
ammar92 previously approved these changes Jun 15, 2023
praseodym
praseodym previously approved these changes Jun 16, 2023
@praseodym
Copy link
Contributor

praseodym commented Jun 21, 2023

I'd say this PR shouldn't close #735 because it only changes Keiko and Octopoes, not the other services. We'll want to change those as part of #735 too.

edit: changed the first post to "Relates to" instead of "Closed"

@underdarknl underdarknl merged commit f7acfb2 into main Jun 27, 2023
@underdarknl underdarknl deleted the feature/unified-poetry-venv-2 branch June 27, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants