Fix: Moving header nav styling to header nav styling file instead of … #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the reasoning behind having two seperated sass files. One with variables and their values and one with the actual styling, using those variables instead of the specific values? As far as I could tell the variables aren't reused, so what's the benefit of having this split up into two files? |
|
The variable files contain the variables that can be used to override any of the specific values we want the user to be able to adjust.
|
TwistMeister
approved these changes
Feb 20, 2023
|
@HeleenSG good to know. Thanks for elaborating :) |
jpbruinsslot
added a commit
that referenced
this pull request
Mar 29, 2023
* main: (96 commits) Updated version number (#123) Updated nav styling options and fixed issues found. Added manon docs nav styling. (#121) fix: set border to 0 on focus-only class (#118) fix: form help styling Added width variable feat: header-navigation width variable fix: added and updated header-navigation variables Updated version (#112) fix: fieldset checkbox alignment horizontal view. Align correctly with elements outside the fieldset. (#114) fix: update tabs variables linkage. (#113) fix: Form help alignment. (#115) fix: removed empty link (#110) fix: call to action button linkage BREAKING CHANGE: Removed: --cta-background-color and --cta-text-color (#107) fix: pagination variable linkage and added styling to have pagination grow within the available space (#109) Fix: Moving header nav styling to header nav styling file instead of navigation. (#108) fix: ghost button variables linkage fix: message counter linkage chore: updating version fix: upgraded navigation styling options and fixing old linkage issues fix small typos (#96) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Moving header nav styling to header nav styling file instead of navigation.
BREAKING CHANGE: From now on use header-navigation to style the header-navigation instead of navigation.