Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Only error if manifest error was a module build failure #59

Merged
merged 1 commit into from
Sep 21, 2016

Conversation

naomiajacobs
Copy link

This allows webpack-rails to be used with non-breaking errors in the webpack manifest (such as linting).

Context: In our app, we use webpack-rails to serve assets to our Jasmine server when running tests. We want to be able to test and develop locally, even if there are webpack errors (like linting), as long as they don't break the webpack build. Webpack's errors are currently given in the manifest as a simple array of strings without any information about the loader that threw the error, so this PR only throws if it sees 'Module build failed' in the string.

Please let me know if you have any questions!

//cc @juanca

This allows webpack-rails to be used with non-breaking errors (such as linting).
@mipearson
Copy link
Owner

Looks good!

@mipearson mipearson merged commit 5575507 into mipearson:master Sep 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants