This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Only error if manifest error was a module build failure #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows webpack-rails to be used with non-breaking errors in the webpack manifest (such as linting).
Context: In our app, we use webpack-rails to serve assets to our Jasmine server when running tests. We want to be able to test and develop locally, even if there are webpack errors (like linting), as long as they don't break the webpack build. Webpack's errors are currently given in the manifest as a simple array of strings without any information about the loader that threw the error, so this PR only throws if it sees 'Module build failed' in the string.
Please let me know if you have any questions!
//cc @juanca