forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from elastic:main #842
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns (#204939) ## Summary This PR enables default execution context tracking (which was added in this [PR](#204547)) for the following plugins: - SLO - Infra - Synthetics |Plugin|Before|After| |---|---|---| |SLO|![image](https://github.com/user-attachments/assets/3f3e4dac-a1e7-4fbd-be6b-ea885c89ad88)|![image](https://github.com/user-attachments/assets/ae76d68d-2970-4aaf-816a-05c161b1e4fe)| |Synthetics|![image](https://github.com/user-attachments/assets/9e6d5bda-1fd0-48e4-a5d8-5f2b0e35cf54)|![image](https://github.com/user-attachments/assets/a016cc78-121a-4381-8786-9ef96f20c028)| |Infra > Inventory|![image](https://github.com/user-attachments/assets/9186d9ba-5789-42dc-9f5c-e06d3e5c1598)|![image](https://github.com/user-attachments/assets/d4da56b8-581c-4be1-bd33-8a62b602392e)| |Infra > Hosts|![image](https://github.com/user-attachments/assets/18a982cb-fedf-4193-b402-8bf2ef8d7052)|![image](https://github.com/user-attachments/assets/4138f985-bf3e-477a-ba71-d6f0e3483ef8)|
… is not enabled or protocol is set to HTTP1 (#204384) ## Summary resolves #194067 Set HTTP2 as default if ssl is enabled. resolves #194065 Add deprecation log if ssl is not enabled or if protocol is set to http1 <img width="1665" alt="Screenshot 2024-12-17 at 17 06 50" src="https://github.com/user-attachments/assets/3bc7ff57-1079-4a27-90d2-88f3e09093d6" /> <img width="1727" alt="Screenshot 2024-12-17 at 17 06 22" src="https://github.com/user-attachments/assets/d5489705-6cd6-4e09-8327-fdd0f54292ea" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
…ops-rule-params package (#204637) ## Summary Resolves #195186 ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Remove obs-ux-onboarding-team from codeowners
… spinner for timeperiod input to suppress alerts is missing form label (#205387) Closes: #204498 ## Description The time input interval box for timeperiod input for suppressing alerts is missing form label Preconditions: Security -> Rules->Detection Rules(SIEM) page is open ## Changes made: `aria-label` attribute was added for mentioned place ## Screen: ![image](https://github.com/user-attachments/assets/0d78a57d-8b96-4d53-ac69-39d3f2ae42ba)
…x-sharedux` (#204959) ## Summary Part of #203163 Relocating only shared-ux-owned plugins for now
…se-ops-rule-params (#204582) Connected with #195187 ## Summary - Moved params of synthetic status monitor rule type to `/response-ops/rule_params/synthetics_monitor_status/` - Moved params of TLS rule type to `/response-ops/rule_params/synthetics_tls/` I created a follow-up issue to handle the places where io-ts is used for params validation in `observability/plugins/synthetics`. #205207 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Connected with #195187 ## Summary - Moved params of duration anomaly rule type to `/response-ops/rule_params/uptime_duration_anomaly/` - Moved params of monitor status rule type to `/response-ops/rule_params/uptime_monitor_status/` - Moved params of TLS rule type to `/response-ops/rule_params/uptime_tls/` - **Did not move anything related to the legacy TLS rule type.** I ran into a similar issue to #205207 for the monitor status rule type. It doesn't block this PR but some follow up work might be needed for `x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/lib/alert_types/lazy_wrapper/validate_monitor_status.ts`. We will probably decide after the new year. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )