Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from elastic:main #842

Merged
merged 9 commits into from
Jan 3, 2025
Merged

[pull] main from elastic:main #842

merged 9 commits into from
Jan 3, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 3, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

kibanamachine and others added 9 commits January 3, 2025 01:11
… is not enabled or protocol is set to HTTP1 (#204384)

## Summary

resolves #194067

Set HTTP2 as default if ssl is enabled. 

resolves #194065

Add deprecation log if ssl is not enabled or if protocol is set to http1

<img width="1665" alt="Screenshot 2024-12-17 at 17 06 50"
src="https://github.com/user-attachments/assets/3bc7ff57-1079-4a27-90d2-88f3e09093d6"
/>

<img width="1727" alt="Screenshot 2024-12-17 at 17 06 22"
src="https://github.com/user-attachments/assets/d5489705-6cd6-4e09-8327-fdd0f54292ea"
/>


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
…ops-rule-params package (#204637)

## Summary

Resolves #195186


### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Remove obs-ux-onboarding-team from codeowners
… spinner for timeperiod input to suppress alerts is missing form label (#205387)

Closes: #204498

## Description 
The time input interval box for timeperiod input for suppressing alerts
is missing form label
Preconditions: Security -> Rules->Detection Rules(SIEM) page is open

## Changes made:

`aria-label` attribute was added for mentioned place

## Screen: 


![image](https://github.com/user-attachments/assets/0d78a57d-8b96-4d53-ac69-39d3f2ae42ba)
…x-sharedux` (#204959)

## Summary

Part of #203163

Relocating only shared-ux-owned plugins for now
…se-ops-rule-params (#204582)

Connected with #195187

## Summary

- Moved params of synthetic status monitor rule type to
`/response-ops/rule_params/synthetics_monitor_status/`
- Moved params of TLS rule type to
`/response-ops/rule_params/synthetics_tls/`

I created a follow-up issue to handle the places where io-ts is used for
params validation in `observability/plugins/synthetics`. #205207

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Connected with #195187

## Summary

- Moved params of duration anomaly rule type to
`/response-ops/rule_params/uptime_duration_anomaly/`
- Moved params of monitor status rule type to
`/response-ops/rule_params/uptime_monitor_status/`
- Moved params of TLS rule type to
`/response-ops/rule_params/uptime_tls/`
- **Did not move anything related to the legacy TLS rule type.**

I ran into a similar issue to #205207 for the monitor status rule type.
It doesn't block this PR but some follow up work might be needed for
`x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/lib/alert_types/lazy_wrapper/validate_monitor_status.ts`.
We will probably decide after the new year.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@pull pull bot added the ⤵️ pull label Jan 3, 2025
@pull pull bot merged commit c8d46ee into miqdigital:main Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants