Minor update to Date::Holidays::CA_ES #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dapter, plz use the one from Date::Holidays if need be
|
Sorry it took me a while to get to this. I'll make a release (and setup continuous integration, and generally put this in order) in a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @miquelruiz
I have some minor improvements to your distribution.
I have made the dependency on Date::Holidays in your test suite optional, based on whether it is installed. I added some tests from Date::Holidays::ES, so the local implementation can be tested. It might need some additional tests to assert the distinction between ES and CA_ES.
I removed your local adapter since I maintain one in Date::Holidays, please use this if need be. Patches are always welcome.
I do not think this PR addresses issue #2, since I am still observing some weirdness, but at least it is a beginning.
If you are not doing Perl any more I would love to take over maintenance of Date::Holidays::CA_ES keeping the distribution alive and with all attributions intact. This just requires that you set me as co-maintainer (COMAINT) on PAUSE.
Looking forward and hoping to hear from you,
Take care and stay safe,
jonasbn