Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predict.py now has 100% coverage #182

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

stevetorr
Copy link
Contributor

@stevetorr stevetorr commented Jun 4, 2020

Closes #178 ; tests the writing methods and the selective atom functionality.

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2020

Codecov Report

Merging #182 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   58.43%   58.62%   +0.18%     
==========================================
  Files          35       35              
  Lines        7523     7523              
==========================================
+ Hits         4396     4410      +14     
+ Misses       3127     3113      -14     
Impacted Files Coverage Δ
flare/predict.py 100.00% <0.00%> (+10.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5562b...b99ede2. Read the comment docs.

Copy link
Collaborator

@jonpvandermause jonpvandermause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stevetorr stevetorr merged commit c91b2dc into master Jun 11, 2020
@stevetorr stevetorr deleted the test/steven/enhanced_predict_tests branch June 11, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More thorough unit tests for predict.py
3 participants