Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an MGP is unpickled and used, routines called within the https://github.com/mir-group/flare/blob/development/flare/mgp/cubic_splines_numba.py cubic splines numba file will attempt to use a variable
dAd
which is only defined whenfilter_coeffs
is called, which seems to only occur during mapping. This adds a call to the calculate_coeffs function when the cubic_splines_numba file is imported, loading it into global memory.