Clarify how to adjust GP hyp masks and cutoffs #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nw13slx feel free to squash and merge if this looks good! |
nw13slx
approved these changes
Jul 9, 2020
flare/gp.py
Outdated
|
|
||
| if hyps_mask is not None: | ||
| self.hyps_mask = hyps_mask | ||
| if self.cutoffs!= hyps_mask['cutoffs']: |
There was a problem hiding this comment.
maybe make cutoff as an argument instead? hyps_mask does not necessarily have a cutoff argument.
flare/gp.py
Outdated
| if self.cutoffs!= hyps_mask['cutoffs']: | ||
| self.adjust_cutoffs(hyps_mask['cutoffs'],train = False, | ||
| new_hyps_mask = hyps_mask) | ||
| self.hyps = hyps_mask['hyps'] |
There was a problem hiding this comment.
same as above. let's just make hyps as an optional input argument.
| >> hyps_mask = pm.as_dict() | ||
| >> hyps = hyps_mask['hyps'] | ||
| >> kernels = hyps_mask['kernels'] | ||
| >> gp_model.update_kernel(kernels, 'mc', hyps_mask) |
There was a problem hiding this comment.
can be revised accordingly.
…are into steven/documentation-update
…documentation-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codifying some advice @nw13slx has given me in private communication into FLARE documentation, and updating the GP update_kernel method to simplify changing an extant GP to use a new set of hyperparameters.