Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate RBCMs onto development branch #238

Merged
merged 5 commits into from
Sep 10, 2020
Merged

Integrate RBCMs onto development branch #238

merged 5 commits into from
Sep 10, 2020

Conversation

stevetorr
Copy link
Contributor

@stevetorr stevetorr commented Sep 8, 2020 •
edited
Loading

Under construction. RBCMs have been excised from the xyz_loop_in_kernel branch so that they can be used by a wider audience to take advantage of faster hyperparameter training.

  • Get RBCMs working alone.
  • Complete full unit tests & docstrings for RBCMs.

PR Review:

  • @nw13slx ensure that no changes have compromised the function of the RBCMs.

@stevetorr stevetorr marked this pull request as ready for review September 8, 2020 01:04
nw13slx
nw13slx requested changes Sep 8, 2020
View reviewed changes
Copy link
Collaborator

@nw13slx nw13slx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for merging the RBCM implementation with the lastest development branch. The unit tests look great! Please change the reference, then it's ready to merge.

flare/gp_algebra.py Outdated Show resolved Hide resolved
flare/rbcm.py Outdated Show resolved Hide resolved
flare/rbcm.py Outdated Show resolved Hide resolved
@stevetorr stevetorr merged commit 1210365 into development Sep 10, 2020
@YuuuXie YuuuXie deleted the steven/feature/rbcm_graft branch February 22, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nw13slx nw13slx nw13slx requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevetorr @nw13slx