Shorten/fix gp aimd test #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpvandermause
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43 : Will no longer attempt to train the GP while testing the TrajectoryTrainer, will just run it with a data set and pre-set hyper parameters.
I can open a new issue to tighten up the unit tests, but this should solve the issue of it hanging / failing on other people's computers.
Tagging @jonpvandermause just to get one more pair of eyes on it and to pull the trigger (Amazon rules, I think, make sense here).
I tried a clean install of this branch on odyssey and the test_gp_from_aimd worked for me in 8 seconds total (for all 5 tests).