Added to / from PMG methods, with pymatgen as an optional import #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 46.96% 47.26% +0.29%
==========================================
Files 37 37
Lines 5636 5677 +41
==========================================
+ Hits 2647 2683 +36
- Misses 2989 2994 +5
Continue to review full report at Codecov.
|
|
Since we added pymatgen to the requirements.txt, we could probably just make it mandatory? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Talked to @dmclark17 about how to handle optional import statements for different libraries. The solution that is apparently the consensus on StackOverflow is to do as I have done below. Would be happy for 2 cents on if this makes sense.