Added flexibility to user to frequency of output writing #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 46.95% 47.44% +0.48%
==========================================
Files 37 37
Lines 5641 5704 +63
==========================================
+ Hits 2649 2706 +57
- Misses 2992 2998 +6
Continue to review full report at Codecov.
|
nw13slx
approved these changes
Sep 25, 2019
|
Could we do the same for otf.py? @stevetorr @nw13slx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been iterating with train_gp_from_AIMD and have found that the Output module only flushing its buffer periodically and therefore intermittently writing to the output files, while computationally more efficient in general, is undesirable for watching it run in real-time. I propose adding a few arguments to the Output class which make it write instantly to the output if the user wishes to follow output in real time and otherwise does not change the functionality of the module.