WIP: GP now takes opt_params argument #92
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to grandfather in
maxiter
andopt_algorithm
as arguments because I thought that breaking everybody's scripts would be rude. I do think that they belongs in theopt_params
argument so we can add it in later if we want. Perhaps we could include a warning thatopt_algorithm
andmaxiter
will be deprecated with V 1.0 and to useopt_params
instead if they are passed in as arguments.Closes #91