Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: GP now takes opt_params argument #92

Merged
merged 2 commits into from
Oct 21, 2019
Merged

Conversation

stevetorr
Copy link
Contributor

@stevetorr stevetorr commented Oct 14, 2019

I decided to grandfather in maxiter and opt_algorithm as arguments because I thought that breaking everybody's scripts would be rude. I do think that they belongs in the opt_params argument so we can add it in later if we want. Perhaps we could include a warning that opt_algorithm and maxiter will be deprecated with V 1.0 and to use opt_params instead if they are passed in as arguments.

Closes #91

@codecov-io
Copy link

codecov-io commented Oct 14, 2019

Codecov Report

Merging #92 into master will increase coverage by 0.06%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   51.74%   51.81%   +0.06%     
==========================================
  Files          31       31              
  Lines        4791     4802      +11     
==========================================
+ Hits         2479     2488       +9     
- Misses       2312     2314       +2
Impacted Files Coverage Δ
flare/gp.py 89.04% <77.77%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d55cab...f9d03cc. Read the comment docs.

Comment on lines +131 to +132
:param opt_param_override: Dictionary of parameters to override
instace's optimzation parameters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a fun place to try out one of Python 3.8's new features! TypedDicts! I actually don't know if this would be a good use case, but if we turned the opt_param_override into a TypedDict then Python's type checker could check the types in the dictionary

I am just looking for use cases of the new features of python so totally unnecessary to actually implement...

@nw13slx nw13slx merged commit f9d03cc into master Oct 21, 2019
@stevetorr stevetorr deleted the feature/steven/gp_opt_params branch November 19, 2019 21:35
@stevetorr stevetorr restored the feature/steven/gp_opt_params branch November 19, 2019 21:35
@stevetorr stevetorr deleted the feature/steven/gp_opt_params branch February 10, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finer control over GP optimization parameters by instance
4 participants