Feature/steven/gpfa checkpoints #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure/steven/gp_opt_params
Revert "GP now takes opt_params argument" This reverts commit 81f9ea5. Unit test patch- missing pickle Import json Import numpy encoder Pep8 errors Fixed bug in checkpoint Bugfix in GPFA Species conversion to coded species Unit test now tests conversion of species
nw13slx
approved these changes
Oct 21, 2019
| @@ -284,6 +299,11 @@ def train_gp(self): | |||
| self.gp.likelihood, self.gp.likelihood_gradient) | |||
| self.train_count += 1 | |||
|
|
|||
| if self.checkpoint_interval \ | |||
There was a problem hiding this comment.
cool. This is nice. Maybe we should also add a variable "last_step_written" to record when the gp was dumped. So it won't dump twice at the end of the run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98 .
Implements checkpoints in GPFA.