-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add immutable entity operator #73
Add immutable entity operator #73
Conversation
@wreulicke why does it have to be breakable? |
@aadrian What does "breakable" mean? |
@aadrian this PR changes behavior with codes like below. public class Subscription {
// this property has getter/setter
private String property.
// this property has no getter/setter.
private String transientProperty
} The So, I say "This PR contains potentially breaking changes..." |
Ah, I overlooked this comment in the pull request. I think the immutable entity is good. But we need a way to keep the current behavior in case users need it. By the way, public class Subscription {
@PrimaryKey(generationType=GenerationType.APPLICATION)
public final Long userId;
public UserInfo(@Column(name = "userId") Long userId) {
this.userId = userId;
}
} |
great! fix it. |
Thanks for your review. I agree with you. I close this PR now, and i will send PR to add test for keep compatibility. |
@wreulicke also please consider the Map support, since this is also a very important feature. |
@aadrian Thanks for your review. By the way, Why do you think that the Map support is important? |
@wreulicke yes indeed, for Clojure too, for Groovy, and also for dynamic tooling (like ETL) that can't use classes, since stuff needs to be dynamic. |
Implements #74.
This PR provides to support immutable entity.
Below entity code works due to this PR.
How do you think of this PR?
This PR contains potentially breaking changes...