Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document filter parameter #341

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Document filter parameter #341

merged 1 commit into from
Mar 1, 2022

Conversation

MisterDA
Copy link
Collaborator

Fix #340.

@craigfe
Copy link
Member

craigfe commented Mar 1, 2022

One unrelated remaining failure due to lwt.5.5.0:

#=== ERROR while compiling lwt.5.5.0 ==========================================#
# context     2.0.10 | win32/x86_64 | ocaml-variants.4.13.1+mingw64c | git+https://github.com/fdopen/opam-repository-mingw.git#opam2
# path        D:/a/alcotest/alcotest/_opam/.opam-switch/build/lwt.5.5.0
# command     D:\a\alcotest\alcotest\_opam\bin\dune.exe build -p lwt -j 2
# exit-code   1
# env-file    D:/.opam/log/lwt-1664-b53f9e.env
# output-file D:/.opam/log/lwt-1664-b53f9e.out
### output ###
# File "_build/.dune/default/src/core/dune", line 8, characters 18-24:
# 8 |  (libraries bytes result seq)
#                       ^^^^^^
# Error: Library "result" not found.
# -> required by library "lwt" in _build/default/src/core
# -> required by _build/default/META.lwt
# -> required by _build/install/default/lib/lwt/META
# -> required by _build/default/lwt.install
# -> required by alias install

I'm not sure why the result dependency from lwt.5.5.0 is not included on win32, given that the dune files seem to require it. Looks like this will no longer be an issue once lwt.5.6.0 is out, since it's dropping the dependency on result completely (ocsigen/lwt#925). CC @raphael-proust.

@craigfe craigfe merged commit 98f3374 into mirage:main Mar 1, 2022
@MisterDA MisterDA deleted the doc-filter branch March 1, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document filter parameter of with_options
2 participants