Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to ipaddr.4.0.0 interfaces and use Macaddr_cstruct #16

Merged
merged 6 commits into from
Jul 16, 2019

Conversation

avsm
Copy link
Member

@avsm avsm commented Jul 13, 2019

No description provided.

@avsm avsm requested a review from hannesm as a code owner July 13, 2019 18:04
@avsm
Copy link
Member Author

avsm commented Jul 15, 2019

Pushed a minor travis fix to get this green, then will merge/release if that's ok by you @hannesm?

@hannesm
Copy link
Member

hannesm commented Jul 15, 2019

@avsm I thought the travis-ci-scripts would deal with repository updates, uh oh but does not like that is the case.

thanks for dealing with that, yes a release sounds fine to me.

@avsm
Copy link
Member Author

avsm commented Jul 15, 2019

some do and some dont for various reasons. It'll all be fixed shortly with the next CI rev that @talex5 is working on in talex5/ocurrent :-)

@hannesm
Copy link
Member

hannesm commented Jul 15, 2019

@avsm is there a design document for the next CI system? would be interesting what kind of features are in scope and which are not.

@hannesm
Copy link
Member

hannesm commented Jul 15, 2019

@avsm CI failed

∗ installed mirage-time-lwt.1.3.0
Done.
+cd /home/opam/opam-repository
sh: 1: cd: can't cd to /home/opam/opam-repository

@avsm
Copy link
Member Author

avsm commented Jul 15, 2019

@hannesm design spec shared by email

@avsm
Copy link
Member Author

avsm commented Jul 15, 2019

Ah, it was using the base travis distro before. I've switched it to use the Docker CI images in f751bef as that'll be much more reliable (and preferred by Travis these days it appears -- the base distro gets very sporadic updates)

@avsm
Copy link
Member Author

avsm commented Jul 15, 2019

This is green now; I can merge and release if you're ok with that @hannesm

@hannesm hannesm merged commit 34aedda into mirage:master Jul 16, 2019
@hannesm
Copy link
Member

hannesm commented Jul 16, 2019

thanks anil!

@avsm avsm deleted the ipaddr-4 branch July 16, 2019 17:54
hannesm added a commit to hannesm/opam-repository that referenced this pull request Jul 16, 2019
CHANGES:

* Update to ipaddr.4.0.0 interfaces (mirage/arp#16 @avsm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants