Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

irmin-cli: change --store irf to --store fs #2234

Closed
metanivek opened this issue Apr 5, 2023 · 0 comments · Fixed by #2243
Closed

irmin-cli: change --store irf to --store fs #2234

metanivek opened this issue Apr 5, 2023 · 0 comments · Fixed by #2243
Labels
area/cli Modify the CLI good-first-issue A problem for Irmin beginners

Comments

@metanivek
Copy link
Member

The Irmin site (example) uses fs for the file system store, but the resolver uses irf, which perhaps was a typo. Either way, lets update it to use fs.

irmin/src/irmin-cli/resolver.ml

Line 344 in be961dc

("irf", Variable_hash irf);

@metanivek metanivek added area/cli Modify the CLI good-first-issue A problem for Irmin beginners labels Apr 5, 2023
@metanivek metanivek linked a pull request May 2, 2023 that will close this issue
irmin-cli: change --store irf to --store fs #2243
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cli Modify the CLI good-first-issue A problem for Irmin beginners
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

irmin-cli: change --store irf to --store fs wyn/irmin
1 participant
@metanivek